Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancements to cli.js and CONTRIBUTING.md #4452

Merged
merged 1 commit into from
Feb 17, 2025
Merged

Enhancements to cli.js and CONTRIBUTING.md #4452

merged 1 commit into from
Feb 17, 2025

Conversation

hyperupcall
Copy link
Member

@hyperupcall hyperupcall commented Feb 17, 2025 •
edited
Loading

  • Update jsconfig.json target to es2022 (old value of ES2018 was not changed when minimum NodeJS version was bumped to v18)
  • Add note about generic file patterns to contributing
  • Improve some error messages

@github-actions github-actions bot added ci ".github/**/*" folder is updated (auto-generated by labeler action) documentation "**/*.md" folder is updated (auto-generated by labeler action) cli.js gruntfile.js is updated (auto-generated by labeler action) labels Feb 17, 2025
@github-actions GitHub Actions
Copy link
Contributor

Thanks for the PR!

This section of the codebase is owned by @madskristensen and @hyperupcall - if they write a comment saying "LGTM" then it will be merged.

@hyperupcall hyperupcall force-pushed the hyperupcall-cli-enhancements branch from 302556d to 56d7c69 Compare February 17, 2025 06:04
@github-actions github-actions bot removed the ci ".github/**/*" folder is updated (auto-generated by labeler action) label Feb 17, 2025
@hyperupcall hyperupcall force-pushed the hyperupcall-cli-enhancements branch 4 times, most recently from 1e529ff to 6f79b31 Compare February 17, 2025 06:39
@hyperupcall hyperupcall force-pushed the hyperupcall-cli-enhancements branch from 6f79b31 to 2cfd21a Compare February 17, 2025 06:39
@hyperupcall hyperupcall changed the title Enhancements to cli.js Enhancements to cli.js and CONTRIBUTING.md Feb 17, 2025
@hyperupcall hyperupcall merged commit 824f523 into SchemaStore:master Feb 17, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@madskristensen madskristensen Awaiting requested review from madskristensen madskristensen is a code owner

Assignees
No one assigned
Labels
cli.js gruntfile.js is updated (auto-generated by labeler action) documentation "**/*.md" folder is updated (auto-generated by labeler action)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@hyperupcall