Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve factor levels in outcome column #337

Draft
wants to merge 11 commits into
base: main
Choose a base branch
from
Draft

Conversation

kelly-sovacool
Copy link
Member

@kelly-sovacool kelly-sovacool commented May 29, 2023

Design discussion w/ @courtneyarmour:

  • this only matters when outcome is binary.
  • force users to supply a factor for outcome column when outcome is binary -- throw an error otherwise.
  • don't use pos_outcome argument - feature bloat.
  • make sure original factor levels preserved in calc perf metrics.

Issues

Change(s) made

Checklist

(Strikethrough any points that are not applicable.)

  • Write unit tests for any new functionality or bug fixes.
  • Update docs if there are any API changes:
    • roxygen comments
    • vignettes
  • Update NEWS.md if this includes any user-facing changes.
  • The check workflow succeeds on your most recent commit. This is always required before the PR can be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant