Skip to content

Commit

Permalink
remove audience altogether from oidc spec in tf
Browse files Browse the repository at this point in the history
  • Loading branch information
GondekNP committed Dec 31, 2023
1 parent 383bb80 commit 10dacce
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 9 deletions.
1 change: 0 additions & 1 deletion main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,6 @@ resource "google_iam_workload_identity_pool_provider" "oidc" {

oidc {
issuer_uri = "https://token.actions.githubusercontent.com"
allowed_audiences = ["https://github.com/SchmidtDSE"]
}

attribute_mapping = {
Expand Down
6 changes: 2 additions & 4 deletions terraform.tfstate
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"version": 4,
"terraform_version": "1.6.0",
"serial": 60,
"serial": 62,
"lineage": "44075ebe-b91a-1e72-3b17-affdfb63c0f1",
"outputs": {},
"resources": [
Expand Down Expand Up @@ -294,9 +294,7 @@
"name": "projects/113009620257/locations/global/workloadIdentityPools/github/providers/oidc-provider",
"oidc": [
{
"allowed_audiences": [
"https://github.com/SchmidtDSE"
],
"allowed_audiences": [],
"issuer_uri": "https://token.actions.githubusercontent.com",
"jwks_json": ""
}
Expand Down
7 changes: 3 additions & 4 deletions terraform.tfstate.backup
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"version": 4,
"terraform_version": "1.6.0",
"serial": 58,
"serial": 60,
"lineage": "44075ebe-b91a-1e72-3b17-affdfb63c0f1",
"outputs": {},
"resources": [
Expand Down Expand Up @@ -295,7 +295,7 @@
"oidc": [
{
"allowed_audiences": [
"github[email protected].com"
"https://github.com/SchmidtDSE"
],
"issuer_uri": "https://token.actions.githubusercontent.com",
"jwks_json": ""
Expand All @@ -310,8 +310,7 @@
"sensitive_attributes": [],
"private": "eyJlMmJmYjczMC1lY2FhLTExZTYtOGY4OC0zNDM2M2JjN2M0YzAiOnsiY3JlYXRlIjoxMjAwMDAwMDAwMDAwLCJkZWxldGUiOjEyMDAwMDAwMDAwMDAsInVwZGF0ZSI6MTIwMDAwMDAwMDAwMH19",
"dependencies": [
"google_iam_workload_identity_pool.pool",
"google_service_account.default"
"google_iam_workload_identity_pool.pool"
]
}
]
Expand Down

0 comments on commit 10dacce

Please sign in to comment.