Skip to content

Commit

Permalink
try cloud build on GA
Browse files Browse the repository at this point in the history
  • Loading branch information
GondekNP committed Dec 31, 2023
1 parent 13c4d32 commit bb82ecf
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 23 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/cloud_build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: Push and Deploy to Cloud Run
on:
push:
branches:
- not_a_branch
- dev

jobs:
setup-build-deploy:
Expand Down
17 changes: 2 additions & 15 deletions main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -118,19 +118,6 @@ resource "google_service_account_iam_binding" "workload_identity_user" {
service_account_id = google_service_account.default.name
role = "roles/iam.workloadIdentityUser"
members = [
"principal://iam.googleapis.com/projects/${google_project.project.number}/locations/global/workloadIdentityPools/${google_iam_workload_identity_pool.pool.workload_identity_pool_id}/subject/${SUBJECT}"
"serviceAccount:${google_service_account.default.email}"
]
}

## We will use GitHub Actions to build and deploy the container image, so we actually don't need this
# resource "google_cloudbuild_trigger" "default" {
# name = "burn-prod-trigger"
# github {
# owner = "SchmidtDSE"
# name = "burn-severity-mapping-poc"
# push {
# branch = "prod"
# }
# }
# filename = "cloudbuild.yaml"
# }
}
6 changes: 2 additions & 4 deletions terraform.tfstate
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"version": 4,
"terraform_version": "1.6.0",
"serial": 53,
"serial": 56,
"lineage": "44075ebe-b91a-1e72-3b17-affdfb63c0f1",
"outputs": {},
"resources": [
Expand Down Expand Up @@ -403,16 +403,14 @@
"etag": "BwYMzVAjNrY=",
"id": "projects/dse-nps/serviceAccounts/[email protected]/roles/iam.workloadIdentityUser",
"members": [
"principal://iam.googleapis.com/projects/113009620257/locations/global/workloadIdentityPools/github"
"serviceAccount:github-actions-service-account@dse-nps.iam.gserviceaccount.com"
],
"role": "roles/iam.workloadIdentityUser",
"service_account_id": "projects/dse-nps/serviceAccounts/[email protected]"
},
"sensitive_attributes": [],
"private": "bnVsbA==",
"dependencies": [
"data.google_project.project",
"google_iam_workload_identity_pool.pool",
"google_service_account.default"
]
}
Expand Down
5 changes: 2 additions & 3 deletions terraform.tfstate.backup
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"version": 4,
"terraform_version": "1.6.0",
"serial": 51,
"serial": 55,
"lineage": "44075ebe-b91a-1e72-3b17-affdfb63c0f1",
"outputs": {},
"resources": [
Expand Down Expand Up @@ -403,15 +403,14 @@
"etag": "BwYMzVAjNrY=",
"id": "projects/dse-nps/serviceAccounts/[email protected]/roles/iam.workloadIdentityUser",
"members": [
"principal://iam.googleapis.com/projects/113009620257/locations/global/workloadIdentityPools/github/attribute.repository"
"principalSet://iam.googleapis.com/projects/dse-nps/locations/global/workloadIdentityPools/github/attribute.repository"
],
"role": "roles/iam.workloadIdentityUser",
"service_account_id": "projects/dse-nps/serviceAccounts/[email protected]"
},
"sensitive_attributes": [],
"private": "bnVsbA==",
"dependencies": [
"data.google_project.project",
"google_iam_workload_identity_pool.pool",
"google_service_account.default"
]
Expand Down

0 comments on commit bb82ecf

Please sign in to comment.