Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: SlimefunTranslation integration #9

Conversation

ybw0014
Copy link
Contributor

@ybw0014 ybw0014 commented Jan 21, 2024

Get the translated item name for player when displaying WAILA.
If SlimefunTranslation is not installed, just display the default name.

@SchnTgaiSpock
Copy link
Owner

im getting this error, using sft 0.4.0, protocollib 5.2.0 and placeholderapi 2.11.4, while looking at an output chest

java.lang.NoSuchMethodError: 'java.lang.String net.guizhanss.slimefuntranslation.core.services.TranslationService.getTranslatedItemName(net.guizhanss.slimefuntranslation.core.users.User, io.github.thebusybiscuit.slimefun4.api.items.SlimefunItem)'
        at io.github.schntgaispock.slimehud.translation.TranslationManager.getItemName(TranslationManager.java:32) ~[SlimeHUD v1.2.7.jar:?]
        at io.github.schntgaispock.slimehud.waila.PlayerWAILA.getFacing(PlayerWAILA.java:67) ~[SlimeHUD v1.2.7.jar:?]
        at io.github.schntgaispock.slimehud.waila.PlayerWAILA.run(PlayerWAILA.java:84) ~[SlimeHUD v1.2.7.jar:?]
        at org.bukkit.craftbukkit.v1_20_R2.scheduler.CraftTask.run(CraftTask.java:101) ~[paper-1.20.2.jar:git-Paper-318]
        at org.bukkit.craftbukkit.v1_20_R2.scheduler.CraftScheduler.mainThreadHeartbeat(CraftScheduler.java:480) ~[paper-1.20.2.jar:git-Paper-318]
        at net.minecraft.server.MinecraftServer.tickChildren(MinecraftServer.java:1470) ~[paper-1.20.2.jar:git-Paper-318]
        at net.minecraft.server.dedicated.DedicatedServer.tickChildren(DedicatedServer.java:446) ~[paper-1.20.2.jar:git-Paper-318]
        at net.minecraft.server.MinecraftServer.tickServer(MinecraftServer.java:1379) ~[paper-1.20.2.jar:git-Paper-318]
        at net.minecraft.server.MinecraftServer.runServer(MinecraftServer.java:1156) ~[paper-1.20.2.jar:git-Paper-318]
        at net.minecraft.server.MinecraftServer.lambda$spin$0(MinecraftServer.java:315) ~[paper-1.20.2.jar:git-Paper-318]
        at java.lang.Thread.run(Thread.java:833) ~[?:?]

the bossbar also doesn't appear

@SchnTgaiSpock
Copy link
Owner

im also getting this:

[14:13:12 INFO]: [SlimefunTranslation] [DEBUG] Loading item translation GOLDEN_12K_HELMET
[14:13:12 ERROR]: [SlimefunTranslation] Invalid item GOLDEN_12K_HELMET
[14:13:12 INFO]: [SlimefunTranslation] [DEBUG] Loading item translation GOLDEN_12K_CHESTPLATE
[14:13:12 ERROR]: [SlimefunTranslation] Invalid item GOLDEN_12K_CHESTPLATE
[14:13:12 INFO]: [SlimefunTranslation] [DEBUG] Loading item translation GOLDEN_12K_LEGGINGS
[14:13:12 ERROR]: [SlimefunTranslation] Invalid item GOLDEN_12K_LEGGINGS
[14:13:12 INFO]: [SlimefunTranslation] [DEBUG] Loading item translation GOLDEN_12K_BOOTS
[14:13:12 ERROR]: [SlimefunTranslation] Invalid item GOLDEN_12K_BOOTS

@SchnTgaiSpock
Copy link
Owner

the only translation files i have are en

@SchnTgaiSpock
Copy link
Owner

SchnTgaiSpock commented Jan 21, 2024

nvm just built from source and it works

@ybw0014
Copy link
Contributor Author

ybw0014 commented Jan 21, 2024

yeah, the new version only available on github, I haven't provided a jar file yet.
The ID of 12k gold armor is misconfigured, Ive just fixed it.

@SchnTgaiSpock SchnTgaiSpock merged commit bfdec28 into SchnTgaiSpock:master Jan 26, 2024
1 check passed
@ybw0014 ybw0014 deleted the upstream/feat/slimefun-translation branch October 29, 2024 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants