Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(28): adding testing packages and sendEmail for confirmation #67

Merged
merged 9 commits into from
Oct 17, 2024

Conversation

404answernotfound
Copy link
Member

@404answernotfound 404answernotfound commented Oct 10, 2024

🔗 Linked issue

#28

  • Added a new /emails page where you will find a button to send a confirmation email.
  • Sends confirmation email once subscription process is completed (right now not working because of Stripe probably)

❓ Type of change

  • 📖 Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@404answernotfound
Copy link
Member Author

I'm not actually receiving emails, but we are sending them.

Screenshot 2024-10-16 at 20 33 13

@TheJoin95
Copy link
Member

Please rebase

@404answernotfound
Copy link
Member Author

@TheJoin95 rebased

@TheJoin95
Copy link
Member

@404answernotfound please check the CI

@TheJoin95
Copy link
Member

Overall looking good, I think we can merge it after the previous comments are going to be resolved, thanks!

@404answernotfound
Copy link
Member Author

Using this PR to also get a start on #29 and #30 which will require admin membership page to be completed before moving forward. This is enough to get us started with making emails work tho, so it's a closing for #28 and a starting point for debugging #29 and #30

To your points @TheJoin95 , we can add env vars

TheJoin95
TheJoin95 previously approved these changes Oct 17, 2024
Copy link
Member

@TheJoin95 TheJoin95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving so that after fixing the lint issues you can merge it

@404answernotfound
Copy link
Member Author

Should have fixed linting issue that didn't come with this PR but we can still fix it here

@404answernotfound 404answernotfound merged commit bf2cfcc into main Oct 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants