Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor events page #102

Merged
merged 124 commits into from
Dec 8, 2023
Merged

Conversation

rennavittorio
Copy link
Contributor

@rennavittorio rennavittorio commented Oct 15, 2023

New Page: Sh-sessions

This Draft PR refers to issue #96 - Create schrodinger session page

Description

The Draft PR contain the redesign of the SH Event Page, according to the Figma shared to the community by @AngyDev .
NOTE: This is a first version and a work in progress.

Here's some points I'd like to bring attention to:

  • the new event.ts file, extracted from the messagges.ts, to mange data more easily and quickly. I'd like to brainstorm together better solutions, if you think, and how we plan to handle event data on the site (eg. creation/update of events)
  • the logic and UI of the proposed filters

Here's some current todos:

  • the redesign of the single event view
  • the "get ticket" button

Any feedback or thoughts about the points above or any other ideas are welcome!

Changes

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications: a brand new event page, with new UI and logic. The page is a core section of the SH website

Screenshots and videos
Dark mode
Screenshot 2023-10-10 alle 21 59 30

Light mode
Screenshot 2023-10-10 alle 21 59 19

The PR fulfills these requirements:

@netlify
Copy link

netlify bot commented Oct 15, 2023

Deploy Preview for suspicious-boyd-b429fe ready!

Name Link
🔨 Latest commit e19fbe5
🔍 Latest deploy log https://app.netlify.com/sites/suspicious-boyd-b429fe/deploys/657357636a308c00083e0cb1
😎 Deploy Preview https://deploy-preview-102--suspicious-boyd-b429fe.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rennavittorio rennavittorio changed the title Feat/session page WIP Create schrodinger session page Oct 15, 2023
@Readpato
Copy link
Member

Hey there! I'm helping on this PR to bring it to a close asap.
To not overstep ourselves, I'll be working in creating a single component for the Card that will be used on either the grid and the featured Event at the top of the page.

@Readpato Readpato force-pushed the feat/session-page branch 2 times, most recently from 9dae262 to 53c0197 Compare November 26, 2023 18:22
@Readpato Readpato marked this pull request as ready for review November 26, 2023 18:25
@TheJoin95
Copy link
Member

@Readpato you have to rebase with main branch, are you able to do it please?

@Readpato Readpato requested a review from Wabri December 8, 2023 17:53
Copy link
Member

@Wabri Wabri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are about a million things changed 😃 I trust in you ❤️‍🔥

@Readpato Readpato merged commit 5456042 into Schroedinger-Hat:main Dec 8, 2023
4 checks passed
@Wabri Wabri changed the title [WIP]: Refactor events page Refactor events page Dec 11, 2023
@Readpato
Copy link
Member

Advances #89

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request urgent Need to be done ASAP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE]: Create schrodinger session page
4 participants