Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(MobileMenu & TheNavbar): convert to UnoCSS, reduce boilerplate #91

Merged
merged 31 commits into from
Sep 7, 2023

Conversation

Readpato
Copy link
Member

@Readpato Readpato commented Aug 21, 2023

Description

  • Update MobileMenu && TheNavbar to utilize UnoCSS when possible
  • Reduce boilerplate in both above mentioned components by utilizing better template logic
  • Create CtaComponent and CtaIcon components that will help us unify and utilize only two components for CTAs.
  • Create useGlobalScrollLock function that blocks document scroll when the MobileMenu is shown.
  • Add minimal lint and formatting to App.vue.
  • Create stylelint script for NPM.
  • Add a nice blurred and reduced opacity style to TheNavbar 😎

Pushes forward #89

Changes

What kind of change does this PR introduce? (check at least one by adding an "x" between the brackets)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications: -

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@Readpato Readpato added the enhancement New feature or request label Aug 21, 2023
@Readpato Readpato self-assigned this Aug 21, 2023
@netlify
Copy link

netlify bot commented Aug 21, 2023

Deploy Preview for suspicious-boyd-b429fe ready!

Name Link
🔨 Latest commit b52b1bc
🔍 Latest deploy log https://app.netlify.com/sites/suspicious-boyd-b429fe/deploys/64f8e1c81983350008a79a3a
😎 Deploy Preview https://deploy-preview-91--suspicious-boyd-b429fe.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Readpato Readpato changed the title refactor(MobileMenu): convert to UnoCSS refactor(MobileMenu & TheNavbar): convert to UnoCSS, reduce boilerplate Sep 6, 2023
@Readpato Readpato merged commit 719ec61 into Schroedinger-Hat:main Sep 7, 2023
4 checks passed
@Readpato Readpato deleted the refactor/mobile-menu branch September 7, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants