-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(MobileMenu & TheNavbar): convert to UnoCSS, reduce boilerplate #91
Merged
Readpato
merged 31 commits into
Schroedinger-Hat:main
from
Readpato:refactor/mobile-menu
Sep 7, 2023
Merged
refactor(MobileMenu & TheNavbar): convert to UnoCSS, reduce boilerplate #91
Readpato
merged 31 commits into
Schroedinger-Hat:main
from
Readpato:refactor/mobile-menu
Sep 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Readpato
requested review from
TheJoin95,
Wabri,
davideimola,
AngyDev,
nicpuppa and
404answernotfound
August 21, 2023 22:08
✅ Deploy Preview for suspicious-boyd-b429fe ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
AngyDev
approved these changes
Aug 22, 2023
A safeguard has been added to the attributes so they wont render simply a component because it has their attribute instead now it will render because it also has a value
Readpato
changed the title
refactor(MobileMenu): convert to UnoCSS
refactor(MobileMenu & TheNavbar): convert to UnoCSS, reduce boilerplate
Sep 6, 2023
AngyDev
approved these changes
Sep 7, 2023
TheJoin95
approved these changes
Sep 7, 2023
Wabri
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
MobileMenu
&&TheNavbar
to utilize UnoCSS when possibleCtaComponent
andCtaIcon
components that will help us unify and utilize only two components for CTAs.useGlobalScrollLock
function that blocks document scroll when theMobileMenu
is shown.App.vue
.stylelint
script for NPM.TheNavbar
😎Pushes forward #89
Changes
What kind of change does this PR introduce? (check at least one by adding an "x" between the brackets)
Does this PR introduce a breaking change? (check one)
If yes, please describe the impact and migration path for existing applications: -
The PR fulfills these requirements:
If adding a new feature, the PR's description includes: