Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: PageHome, add logo SVG, modify global SCSS classes #95

Merged
merged 33 commits into from
Sep 19, 2023

Conversation

Readpato
Copy link
Member

Description

  • Delete TheMain.vue and make it a single component in PageHome.vue
  • Reduce and optimize above mentioned component boilerplate and logic
  • Add SVG component of our logo
  • Replace SCSS global classes for CTA Components in CtaComponent.vue
  • Modify tsconfig.json to be alphabetically ordered and add proper variable casing
  • On App.vue: add specific typography rules for large screens and calculate minimum page height based off TheNavbar
  • Create getAssetURL function that will allow us to handle static assets with Vite.

Pushes forward #89

Changes

What kind of change does this PR introduce? (check at least one by adding an "x" between the brackets)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes

  • No

  • For more information on the supported file image/file types and the file size limits, please refer
    to the following link.

The PR fulfills these requirements:

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

@Readpato Readpato added the enhancement New feature or request label Sep 17, 2023
@Readpato Readpato self-assigned this Sep 17, 2023
@netlify
Copy link

netlify bot commented Sep 17, 2023

Deploy Preview for suspicious-boyd-b429fe ready!

Name Link
🔨 Latest commit bb77df6
🔍 Latest deploy log https://app.netlify.com/sites/suspicious-boyd-b429fe/deploys/65073bb2fe8c00000742667d
😎 Deploy Preview https://deploy-preview-95--suspicious-boyd-b429fe.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@nicpuppa nicpuppa merged commit 3b561f4 into Schroedinger-Hat:main Sep 19, 2023
4 checks passed
@Readpato Readpato deleted the refactor/page-home branch September 26, 2023 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants