Skip to content

Conversation

@Junjiequan
Copy link
Member

@Junjiequan Junjiequan commented Nov 13, 2025

Description

This PR disables image sort in dynamic material table

Motivation

Sorting image does not give any value

Fixes:

Please provide a list of the fixes implemented in this PR

  • Items added

Changes:

Please provide a list of the changes implemented by this PR

  • changes made

Tests included

  • Included for each change/fix?
  • Passing? (Merge will not be approved unless this is checked)

Documentation

  • swagger documentation updated [required]
  • official documentation updated [nice-to-have]

official documentation info

If you have updated the official documentation, please provide PR # and URL of the pages where the updates are included

Backend version

  • Does it require a specific version of the backend
  • which version of the backend is required:

Summary by Sourcery

Enhancements:

  • Prevent image columns from being sortable by adding a check to the disabled sorting condition in the table header

@Junjiequan Junjiequan requested a review from a team as a code owner November 13, 2025 10:16
@Junjiequan Junjiequan requested a review from nitrosx November 13, 2025 10:16
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@Junjiequan Junjiequan changed the title fix(table): disable sorting for 'image' column in dynamic material table fix(hot fix): disable sorting for 'image' column Nov 14, 2025
@Junjiequan Junjiequan changed the base branch from master to release November 14, 2025 09:05
@Junjiequan Junjiequan added this pull request to the merge queue Nov 14, 2025
Merged via the queue into release with commit 6451bf9 Nov 14, 2025
2 checks passed
@Junjiequan Junjiequan deleted the disable-dynamic-table-image-sort branch November 14, 2025 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants