Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additinal CONTAINS_STRING option for characteristic filter #974

Closed

Conversation

linupi
Copy link

@linupi linupi commented Jun 10, 2022

Description

In SciCatProject/backend-v3#680 we propose a filter option for partially matching strings and here we added the corresponding frontend modifications.

Motivation

imagine you'd have the following metadata for a dataset

"scientificMetadata": {
        "localContact": "John Doe",
        "experimentalists": [
                "John Doe",
                "Max Mustermann"
         ]

now we would like to filter all datasts where John participated in the measurement (or was local contact respectivly). So far this type of query was not possible using the options offered when clicking add condition in the search box as there was only an option to exactly match complete strings and no option for partial string matching or matching strings in lists.

Changes:

new_contains_string_option

condition_label

Tests included/Docs Updated?

  • Included for each change/fix?
  • Passing? (Merge will not be approved unless this is checked)
  • Docs updated?
  • New packages used/requires npm install?
  • Toggle added for new features?
  • Requires update of SciCat backend API?

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2472997950

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • 5 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.1%) to 73.5%

Files with Coverage Reduction New Missed Lines %
src/app/datasets/dataset-detail/dataset-detail.component.ts 1 80.37%
src/app/jobs/jobs-dashboard/jobs-dashboard.component.ts 4 58.44%
Totals Coverage Status
Change from base Build 2467375133: -0.1%
Covered Lines: 3582
Relevant Lines: 4473

💛 - Coveralls

@bpedersen2
Copy link
Contributor

rebase onto current HEAD and created a fresh pull request #1342

@bpedersen2 bpedersen2 closed this Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants