Refactors based on comments from JoA and AA

taca/analysis/analysis.py

@@ -156,19 +156,17 @@ def _upload_to_statusdb(run):
             "Setup": {"Software": run.CONFIG.get("bcl2fastq", {})}
         }
     # Keep PDC archive date if there is one already
-    run_vals = run.split("_")
+    run_vals = parser.obj["name"].split("_")
     if len(run_vals[0]) == 8:
         run_date = run_vals[0][2:]
     else:
         run_date = run_vals[0]
     run_fc = f"{run_date}_{run_vals[-1]}"
-    try:
-        doc = db.view("names/name", reduce=False, include_docs=True)[run_fc].rows[0].doc
+    db_rows = db.view("names/name", reduce=False, include_docs=True)[run_fc].rows
+    if db_rows:
+        doc = db_rows[0].doc
         if doc.get("pdc_archived") and not parser.obj.get("pdc_archived"):
             parser.obj["pdc_archived"] = doc.get("pdc_archived")
-    # New FC which does not exist
-    except IndexError:
-        pass
 
     statusdb.update_doc(db, parser.obj, over_write_db_entry=True)