Change db names #422
Closed
Change db names #422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aanil
reviewed
Apr 18, 2024
| self.name_view = {k.key: k.id for k in self.db.view("names/name", reduce=False)} | ||
| self.proj_list = { | ||
| k.key: k.value | ||
| for k in self.db.view("names/project_ids_list", reduce=False) | ||
| for k in self.flowcells_db.view("names/project_ids_list", reduce=False) | ||
| if k.key | ||
| } | ||
|
|
||
|
|
||
| class X_FlowcellRunMetricsConnection(StatusdbSession): | ||
| def __init__(self, config, dbname="x_flowcells"): |
There was a problem hiding this comment.
Is the dbname here used in taca_ngi_pipeline?
There was a problem hiding this comment.
Yes you're right. It is reused in the common methods in the StatusDBSession class. Hmm, might have to rethink this.
|
Closing since it became a bit more complicated than I first hoped. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An effort to standardise variable names that refers to a single specific StatusDB database.
In a few cases, I have dropped the option
dbnameto some classes, I've checked with taca-ngi-pipeline as well that these options were not used. Might need to check elsewhere as well if these classes are used there.