Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refine versionlog check and bump versionlog #423

Merged
merged 1 commit into from
Apr 24, 2024
Merged

Refine versionlog check and bump versionlog #423

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions .github/workflows/check-log.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,8 @@ jobs:

- name: Check for VERSIONLOG.MD changes
id: versionlog_check
# 1) Find the common ancestor between the current HEAD and the base branch
# 2) Then see if the versionlog has been updated in the PR since it diverged
# from the common ancestor
run: |
PR_BASE_SHA=$(git merge-base HEAD ${{ github.event.pull_request.base.sha }})
FILE_CHANGED=$(git diff --name-only $PR_BASE_SHA HEAD | grep 'VERSIONLOG.md' || true)
FILE_CHANGED=$(git diff --name-only ${{ github.event.pull_request.base.sha }} HEAD | grep 'VERSIONLOG.md' || true)
if [ -n "$FILE_CHANGED" ]; then
echo "VERSIONLOG.MD has been changed."
else
Expand Down
4 changes: 4 additions & 0 deletions VERSIONLOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,9 @@
# TACA Version Log

## 20240422.1

Refine GHA VERSIONLOG.md check to compare to merge-base, not branch-base.

## 20240410.1

Expand test coverage by starting and checking demultiplexing for a NovaSeqXPlus run.
Expand Down
Loading