Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issues appearing after deploment of PR #293 #299

Merged
merged 12 commits into from
Jan 4, 2024
Merged

Fix issues appearing after deploment of PR #293 #299

merged 12 commits into from
Jan 4, 2024

Conversation

kedhammar
Copy link

Part of validation 23_31

@kedhammar
Copy link
Author

There had been some reports of missing external packages, so I used the tool pipreqs on the repo to list all external dependencies and updated the requirements.txt file. Also added pipreqs to the dev requirements because it seems useful.

@kedhammar
Copy link
Author

  • Thoroughly updated requirements based on running pipreqs in brand new environment on GHA
  • Made a small custom Bash script to run in GHA. Job will run pipreqs and see whether it agrees with requirements.txt. Hopefully this will catch any packages that are changed in the codebase without being changed in requirements.txt in the future.

alneberg
alneberg approved these changes Jan 2, 2024
View reviewed changes
Copy link
Member

@alneberg alneberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Didn't know about pipreqs before!

alneberg
alneberg approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member

@alneberg alneberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting looks good!

@kedhammar kedhammar merged commit 74aba6a into SciLifeLab:master Jan 4, 2024
6 checks passed
@kedhammar kedhammar deleted the gha branch January 4, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alneberg alneberg alneberg approved these changes

@chuan-wang chuan-wang chuan-wang approved these changes

Assignees
No one assigned
Labels
bug enhancement validation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kedhammar @alneberg @chuan-wang