Merge pull request #186 from AayushSabharwal/as/odesol-internals

fix: don't depend on `ODESolution` internals

Project.toml

@@ -59,7 +59,7 @@ Random = "1.10"
 ReTestItems = "1.23.1"
 RecursiveArrayTools = "3.4"
 Reexport = "1.2"
-SciMLBase = "2.31"
+SciMLBase = "2.40"
 Setfield = "1"
 SparseArrays = "1.10"
 SparseDiffTools = "2.14"

src/utils.jl

@@ -360,17 +360,7 @@ end
 # Construct BVP Solution
 function __build_solution(prob::BVProblem, odesol, nlsol)
     retcode = ifelse(SciMLBase.successful_retcode(nlsol), odesol.retcode, nlsol.retcode)
-    return __solution_new_original_retcode(odesol, nlsol, retcode, nlsol.resid)
-end
-
-function __solution_new_original_retcode(
-        sol::ODESolution{T, N}, original, retcode, resid) where {T, N}
-    return ODESolution{
-        T, N, typeof(sol.u), typeof(sol.u_analytic), typeof(sol.errors), typeof(sol.t),
-        typeof(sol.k), typeof(sol.prob), typeof(sol.alg), typeof(sol.interp),
-        typeof(sol.stats), typeof(sol.alg_choice), typeof(resid), typeof(original)}(
-        sol.u, sol.u_analytic, sol.errors, sol.t, sol.k, sol.prob, sol.alg, sol.interp,
-        sol.dense, sol.tslocation, sol.stats, sol.alg_choice, retcode, resid, original)
+    return SciMLBase.solution_new_original_retcode(odesol, nlsol, retcode, nlsol.resid)
 end
 
 # Fix3