Fix single shooting failing

SciML · Oct 26, 2024 · 3994974 · 3994974
1 parent b799b32
commit 3994974
Showing 1 changed file with 11 additions and 9 deletions.
diff --git a/lib/BoundaryValueDiffEqShooting/test/orbital_tests.jl b/lib/BoundaryValueDiffEqShooting/test/orbital_tests.jl
@@ -57,15 +57,16 @@
         AutoFiniteDiff(; fdtype = Val(:forward)), AutoSparse(AutoFiniteDiff()))
         nlsolve = TrustRegion(; autodiff)
 
-        sol = solve(
-            bvp, Shooting(DP5(); nlsolve); force_dtmin = true, abstol = 1e-6, reltol = 1e-6,
-            verbose = false, odesolve_kwargs = (abstol = 1e-6, reltol = 1e-3))
+        jac_alg = BVPJacobianAlgorithm(; nonbc_diffmode = autodiff,
+            bc_diffmode = BoundaryValueDiffEqShooting.__get_non_sparse_ad(autodiff))
+
+        sol = solve(bvp, Shooting(DP5(); nlsolve, jac_alg); force_dtmin = true,
+            abstol = 1e-6, reltol = 1e-6, verbose = false,
+            odesolve_kwargs = (abstol = 1e-6, reltol = 1e-3))
 
         @test SciMLBase.successful_retcode(sol)
         @test norm(sol.resid, Inf) < 1e-6
 
-        jac_alg = BVPJacobianAlgorithm(; nonbc_diffmode = autodiff,
-            bc_diffmode = BoundaryValueDiffEqShooting.__get_non_sparse_ad(autodiff))
         sol = solve(bvp, MultipleShooting(10, DP5(); nlsolve, jac_alg);
             force_dtmin = true, abstol = 1e-6, reltol = 1e-6,
             verbose = false, odesolve_kwargs = (abstol = 1e-6, reltol = 1e-3))
@@ -82,14 +83,15 @@
         AutoSparse(AutoForwardDiff(; chunksize = 6)))
         nlsolve = TrustRegion(; autodiff)
 
-        sol = solve(
-            bvp, Shooting(DP5(); nlsolve); force_dtmin = true, abstol = 1e-6, reltol = 1e-6,
-            verbose = false, odesolve_kwargs = (abstol = 1e-6, reltol = 1e-3))
+        jac_alg = BVPJacobianAlgorithm(; nonbc_diffmode = autodiff, bc_diffmode = autodiff)
+
+        sol = solve(bvp, Shooting(DP5(); nlsolve, jac_alg); force_dtmin = true,
+            abstol = 1e-6, reltol = 1e-6, verbose = false,
+            odesolve_kwargs = (abstol = 1e-6, reltol = 1e-3))
 
         @test SciMLBase.successful_retcode(sol)
         @test norm(sol.resid, Inf) < 1e-6
 
-        jac_alg = BVPJacobianAlgorithm(; nonbc_diffmode = autodiff, bc_diffmode = autodiff)
         sol = solve(bvp, MultipleShooting(10, DP5(); nlsolve, jac_alg);
             force_dtmin = true, abstol = 1e-6, reltol = 1e-6,
             verbose = false, odesolve_kwargs = (abstol = 1e-6, reltol = 1e-3))