Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix precompilation on 1.11 #227

Merged
merged 2 commits into from
Oct 27, 2024
Merged

Fix precompilation on 1.11 #227

merged 2 commits into from
Oct 27, 2024

Conversation

ErikQQY
Copy link
Member

@ErikQQY ErikQQY commented Oct 26, 2024

#207

This should also be able to fix CI issues on 1.11

Copy link
Contributor

github-actions bot commented Oct 26, 2024

Benchmark Results

master 3994974... master/39949746b60ac5...
Simple Pendulum/IIP/BoundaryValueDiffEqMIRK.MIRK2() 6.57 ± 0.42 ms 6.51 ± 0.49 ms 1.01
Simple Pendulum/IIP/BoundaryValueDiffEqMIRK.MIRK3() 2.42 ± 0.21 ms 2.42 ± 0.2 ms 1
Simple Pendulum/IIP/BoundaryValueDiffEqMIRK.MIRK4() 0.858 ± 0.14 ms 0.848 ± 0.13 ms 1.01
Simple Pendulum/IIP/BoundaryValueDiffEqMIRK.MIRK5() 0.908 ± 0.16 ms 0.918 ± 0.17 ms 0.99
Simple Pendulum/IIP/BoundaryValueDiffEqMIRK.MIRK6() 1.03 ± 0.2 ms 1.02 ± 0.2 ms 1.01
Simple Pendulum/IIP/MultipleShooting(10, Tsit5; grid_coarsening = false) 1.99 ± 0.6 ms 1.99 ± 0.6 ms 0.999
Simple Pendulum/IIP/MultipleShooting(10, Tsit5; grid_coarsening = true) 3.64 ± 0.96 ms 3.58 ± 0.93 ms 1.02
Simple Pendulum/IIP/MultipleShooting(100, Tsit5; grid_coarsening = false) 0.058 ± 0.015 s 0.0556 ± 0.015 s 1.04
Simple Pendulum/IIP/MultipleShooting(100, Tsit5; grid_coarsening = true) 0.071 ± 0.017 s 0.0701 ± 0.017 s 1.01
Simple Pendulum/IIP/Shooting(Tsit5()) 0.246 ± 0.073 ms 0.242 ± 0.076 ms 1.02
Simple Pendulum/OOP/BoundaryValueDiffEqMIRK.MIRK2() 0.0393 ± 0.00098 s 0.0396 ± 0.0034 s 0.992
Simple Pendulum/OOP/BoundaryValueDiffEqMIRK.MIRK3() 11.5 ± 0.81 ms 11.6 ± 1.1 ms 0.996
Simple Pendulum/OOP/BoundaryValueDiffEqMIRK.MIRK4() 3.37 ± 0.26 ms 3.38 ± 0.3 ms 0.996
Simple Pendulum/OOP/BoundaryValueDiffEqMIRK.MIRK5() 3.47 ± 0.3 ms 3.45 ± 0.34 ms 1.01
Simple Pendulum/OOP/BoundaryValueDiffEqMIRK.MIRK6() 3.66 ± 0.36 ms 3.61 ± 0.39 ms 1.02
Simple Pendulum/OOP/MultipleShooting(10, Tsit5; grid_coarsening = false) 3.64 ± 2.6 ms 3.58 ± 2.6 ms 1.01
Simple Pendulum/OOP/MultipleShooting(10, Tsit5; grid_coarsening = true) 6.45 ± 4.3 ms 6.4 ± 4.3 ms 1.01
Simple Pendulum/OOP/MultipleShooting(100, Tsit5; grid_coarsening = false) 0.114 ± 0.011 s 0.112 ± 0.0091 s 1.02
Simple Pendulum/OOP/MultipleShooting(100, Tsit5; grid_coarsening = true) 0.137 ± 0.014 s 0.139 ± 0.01 s 0.99
Simple Pendulum/OOP/Shooting(Tsit5()) 0.599 ± 0.15 ms 0.607 ± 0.35 ms 0.987
time_to_load 33.5 ± 0.08 s 33.3 ± 0.31 s 1.01

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

@@ -55,13 +55,13 @@ DiffEqDevTools = "2.44"
FastAlmostBandedMatrices = "0.1.1"
FastClosures = "0.3"
ForwardDiff = "0.10.36"
JET = "0.8"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any idea why compathelper didn't pick it up?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think CompatHelper only helps with compats for dependencies right? Since we are using JET in testing, CompatHelper would not be able to pick them.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might have to do someething with subdirs? @ArnoStrouwen has done this thing before
https://github.com/SciML/OrdinaryDiffEq.jl/blob/master/.github/workflows/CompatHelper.yml#L26

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChrisRackauckas ChrisRackauckas merged commit 0a0c735 into SciML:master Oct 27, 2024
21 of 22 checks passed
@ChrisRackauckas
Copy link
Member

@ErikQQY you should have the ability to tag already. Have fun with these 😅

@ErikQQY ErikQQY deleted the qqy/bump branch October 27, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants