-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix precompilation on 1.11 #227
Conversation
Benchmark Results
Benchmark PlotsA plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR. |
@@ -55,13 +55,13 @@ DiffEqDevTools = "2.44" | |||
FastAlmostBandedMatrices = "0.1.1" | |||
FastClosures = "0.3" | |||
ForwardDiff = "0.10.36" | |||
JET = "0.8" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any idea why compathelper didn't pick it up?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think CompatHelper only helps with compats for dependencies right? Since we are using JET in testing, CompatHelper would not be able to pick them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might have to do someething with subdirs? @ArnoStrouwen has done this thing before
https://github.com/SciML/OrdinaryDiffEq.jl/blob/master/.github/workflows/CompatHelper.yml#L26
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ErikQQY you should have the ability to tag already. Have fun with these 😅 |
#207
This should also be able to fix CI issues on 1.11