Update Optimization/parameter fitting tutorial #1149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TorkelE
commented
Dec 18, 2024
TorkelE
commented
Dec 18, 2024
| @@ -24,7 +28,7 @@ ps_true = [:kB => 1.0, :kD => 0.1, :kP => 0.5] | |||
| using OrdinaryDiffEqDefault | |||
| oprob_true = ODEProblem(rn, u0, (0.0, 10.0), ps_true) | |||
| true_sol = solve(oprob_true) | |||
| data_sol = solve(oprob_true; saveat=1.0) | |||
| data_sol = solve(oprob_true; saveat = 1.0) | |||
There was a problem hiding this comment.
I think when I wrote these I didn't use to put spaces around = in kwargs, but that should be changed to conform to standard. At some point I will have a look at more tutorials to see if there are other places I don't use the SciML standard.
|
@TorkelE is this ok to merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes DiffEqParamEstim from the tutorial. Since we now create a full cost function here, I simply introduce all relevant concepts directly in this tutorial (instead as before, having some in the behaviour optimisation tutorial, which hence have seen a decent amount of change as well).