Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: added some edge cases in reactionsystem.jl and network_properties.jl #1158

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sivasathyaseeelan
Copy link

@sivasathyaseeelan sivasathyaseeelan commented Jan 4, 2025

I have added some edge cases in reactionsystem.jl and network_properties.jl which were not tested before.

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

@TorkelE
Copy link
Member

TorkelE commented Jan 4, 2025

Looks good to me, but @isaacsas or @vyudu that are familiar with network properties should probably gave a look as well.

@vyudu
Copy link
Collaborator

vyudu commented Jan 5, 2025

These tests look good to me too, thanks! Note to self that it'd probably be a good idea to rename ratematrix at some point, since fluxmat is being added it could cause some confusion

@isaacsas
Copy link
Member

isaacsas commented Jan 6, 2025

Thanks @sivasathyaseeelan. I will merge assuming tests pass ok.

@isaacsas
Copy link
Member

isaacsas commented Jan 6, 2025

@TorkelE this seems to be a new test failure that just started on master. Any idea about it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants