Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation of save_start and save_end #977

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ArneBouillon
Copy link

Fixes SciML/OrdinaryDiffEq.jl#1842

A proposal to clarify the complicated current behaviour of save_start and save_end in the documentation.

Comment on lines +784 to +785
as the final timepoint. This setting is overridden by other saving settings when set to
`false`. Defaults to
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That shouldn't be the case. save_start and save_end should be concrete and overriding in that sense. The solution here isn't to document a current bug.

Copy link
Author

@ArneBouillon ArneBouillon Dec 17, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's on me then; I interpreted SciML/OrdinaryDiffEq.jl#1842 (comment) to mean that the current behaviour should be documented. I'll mark both PRs for this as WIP.

Let's discuss this in more detail in that issue to keep everything centralised.

@ArneBouillon ArneBouillon marked this pull request as draft December 17, 2023 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strange behavior of save_at=false
2 participants