Add guesser #23
Merged
Add guesser #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisRackauckas
approved these changes
Aug 2, 2024
|
That's a neat retrofit into the pre-existing function signatures indeed. |
|
In fact, now it might be worth importing this functionality from here in DataInterpolations since this package is already a dependency |
|
Yes that's the plan, to make DataInterpolations.jl just be a case that uses this, and then we can tackle the other interpolations the same way. |
|
Yes, I'm doing that here: SciML/DataInterpolations.jl#323 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move indexing functionality from
DataInterpolations.jltoFindFirstFunctions.jlas discussed in SciML/DataInterpolations.jl#198 (props to @DaniGlez for the functionality from that PR moved here!)