-
-
Notifications
You must be signed in to change notification settings - Fork 203
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement new discrete saving functionality #2728
feat: implement new discrete saving functionality #2728
Conversation
src/systems/clock_inference.jl
Outdated
@@ -186,6 +186,10 @@ function split_system(ci::ClockInference{S}) where {S} | |||
end | |||
tss[id] = ts_i | |||
end | |||
tss[continuous_id], tss[1] = tss[1], tss[continuous_id] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We cannot assume continuous_id
always exists.
da26283
to
054fe1f
Compare
src/systems/clock_inference.jl
Outdated
@@ -186,6 +186,13 @@ function split_system(ci::ClockInference{S}) where {S} | |||
end | |||
tss[id] = ts_i | |||
end | |||
if continuous_id !== 0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is continuous_id
defined in this function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line 163
aa3f0ba
to
af37ae8
Compare
9044096
to
e3c62d1
Compare
e3c62d1
to
616000c
Compare
616000c
to
74922ed
Compare
Waiting for SciML/SciMLBase.jl#743 |
ef1e4af
to
c3b7726
Compare
c3b7726
to
3a073ec
Compare
Requires:
is_parameter_timeseries
trait, improve parameter timeseries indexing SymbolicIndexingInterface.jl#75AbstractDiffEqArray
RecursiveArrayTools.jl#372PR is based off of this branch right now, will rebase onRebasedmaster
once the above PR is mergedChecklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.