fix: Add metadata getters #3334
Open
+151
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@AayushSabharwal Haven't change |
|
Yeah go for it |
|
add to the docs section on metadata? |
|
This one should be ready |
AayushSabharwal
requested changes
Jan 17, 2025
|
|
||
| meta = ( | ||
| var = var, | ||
| vartype, | ||
| variable_source, |
There was a problem hiding this comment.
Changing this key is breaking
docs/src/basics/Variable_metadata.md
Outdated
|
|
||
| ## Units | ||
|
|
||
| Units for variables can be designated using symbolic metadata. For more information, please see the [model validation and units](@ref units) section of the docs. Note that `getunit` is equivalent to `get_unit`. |
There was a problem hiding this comment.
getunit and get_unit aren't equivalent
There was a problem hiding this comment.
Ah never mind, I read the code wrong
There was a problem hiding this comment.
Can we make them not equivalent? Having two functions do the same thing doesn't really help. get_unit can do all the unit propagation it currently does, and getunit should just make it get the VariableUnit metadata.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2643. Adds getters for
connect, unit, misc