Skip to content

Conversation

@AayushSabharwal
Copy link
Member

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

@github-actions
Copy link
Contributor

Benchmark Results (Julia vlts)

Time benchmarks
master 9b085d8... master / 9b085d8...
ODEProblem 0.0903 ± 0.0062 s 0.097 ± 0.0063 s 0.931 ± 0.088
init 0.0585 ± 0.0021 ms 0.0584 ± 0.0017 ms 1 ± 0.046
large_parameter_init/ODEProblem 0.99 ± 0.0074 s 1.02 ± 0.0055 s 0.968 ± 0.0089
large_parameter_init/init 0.11 ± 0.0026 ms 0.109 ± 0.0028 ms 1.01 ± 0.035
mtkcompile 0.0342 ± 0.0013 s 0.0346 ± 0.00091 s 0.987 ± 0.046
time_to_load 5.3 ± 0.069 s 5.23 ± 0.049 s 1.01 ± 0.016
Memory benchmarks
master 9b085d8... master / 9b085d8...
ODEProblem 0.655 M allocs: 22 MB 0.655 M allocs: 22 MB 1
init 0.892 k allocs: 0.0461 MB 0.892 k allocs: 0.046 MB 1
large_parameter_init/ODEProblem 4.15 M allocs: 0.161 GB 4.15 M allocs: 0.161 GB 1
large_parameter_init/init 1.74 k allocs: 0.0857 MB 1.74 k allocs: 0.0856 MB 1
mtkcompile 0.225 M allocs: 8.35 MB 0.225 M allocs: 8.35 MB 1
time_to_load 0.153 k allocs: 14.5 kB 0.153 k allocs: 14.5 kB 1

@github-actions
Copy link
Contributor

Benchmark Results (Julia v1)

Time benchmarks
master 9b085d8... master / 9b085d8...
ODEProblem 0.0967 ± 0.0058 s 0.0945 ± 0.0067 s 1.02 ± 0.095
init 0.0441 ± 0.011 ms 0.0438 ± 0.011 ms 1.01 ± 0.36
large_parameter_init/ODEProblem 1.15 ± 0.028 s 1.14 ± 0.03 s 1.01 ± 0.037
large_parameter_init/init 0.0768 ± 0.017 ms 0.0774 ± 0.018 ms 0.992 ± 0.32
mtkcompile 0.0341 ± 0.0013 s 0.0343 ± 0.003 s 0.995 ± 0.096
time_to_load 4.62 ± 0.014 s 4.62 ± 0.02 s 0.998 ± 0.0053
Memory benchmarks
master 9b085d8... master / 9b085d8...
ODEProblem 0.67 M allocs: 22 MB 0.668 M allocs: 22 MB 1
init 0.797 k allocs: 30.6 kB 0.797 k allocs: 30.5 kB 1
large_parameter_init/ODEProblem 4.39 M allocs: 0.162 GB 4.41 M allocs: 0.163 GB 0.992
large_parameter_init/init 1.64 k allocs: 0.0596 MB 1.64 k allocs: 0.0594 MB 1
mtkcompile 0.231 M allocs: 7.9 MB 0.231 M allocs: 7.89 MB 1
time_to_load 0.149 k allocs: 11.1 kB 0.149 k allocs: 11.1 kB 1

@ChrisRackauckas
Copy link
Member

Add a test for isbitstype?

@AayushSabharwal
Copy link
Member Author

Yeah I'm working on it. It's astonishing how many tests break if I change the SizedVector to an SVector

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants