Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add parameters to PID controllers #336

Merged
merged 5 commits into from
Oct 16, 2024
Merged

add parameters to PID controllers #336

merged 5 commits into from
Oct 16, 2024

Conversation

baggepinnen
Copy link
Contributor

@baggepinnen baggepinnen commented Oct 16, 2024

@AayushSabharwal some tests are failing with errors like this

LimPI: Error During Test at /home/fredrikb/.julia/dev/ModelingToolkitStandardLibrary/test/Blocks/continuous.jl:232
  Got exception outside of a @test
  Could not evaluate value of parameter pi_controller_lim₊limiter₊u_start. Missing values for variables in expression (1//2)*(u_max + u_min).

There are default values for the parameters u_max, u_min, so it should be possible to figure out the default for pi_controller_lim₊limiter₊u_start

@baggepinnen baggepinnen merged commit fc6c413 into main Oct 16, 2024
6 of 8 checks passed
@baggepinnen baggepinnen deleted the pi_params branch October 16, 2024 11:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants