-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use a proper polyalgorithm algorithm type #278
Conversation
I thing that might break is if someone was writing |
Codecov Report
@@ Coverage Diff @@
## master #278 +/- ##
===========================================
- Coverage 93.58% 48.69% -44.89%
===========================================
Files 19 19
Lines 1807 1805 -2
===========================================
- Hits 1691 879 -812
- Misses 116 926 +810
... and 16 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
no |
@ChrisRackauckas is the forwarddiff linear solve failure from nonlinear solve or something changed in linear solve? |
That's a LinearSolve thing, don't worry about it. |
Can you make the 23 tests more robust? |
Probably disable the |
Or make it simpler, like number of successes > 5 |
Adding this since it makes it easy to write type-stable polyalgorithms. Once this is in we can simply define a custom polyalgorithm algorithm for #277 as well.