Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable protective check by default #307

Merged
merged 2 commits into from
Dec 8, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 5 additions & 14 deletions test/23_test_problems.jl
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,7 @@ function test_on_library(problems, dicts, alg_ops, broken_tests, ϵ = 1e-4;
@testset "$idx: $(dict["title"])" begin
for alg in alg_ops
try
sol = solve(nlprob, alg; maxiters = 10000,
termination_condition = AbsNormTerminationMode())
sol = solve(nlprob, alg; maxiters = 10000)
problem(res, sol.u, nothing)

skip = skip_tests !== nothing && idx in skip_tests[alg]
Expand Down Expand Up @@ -101,18 +100,10 @@ end
broken_tests[alg_ops[2]] = [1, 5, 6, 8, 11, 18]
broken_tests[alg_ops[3]] = [1, 4, 5, 6, 9, 11]
broken_tests[alg_ops[4]] = [1, 5, 6, 8, 11]
broken_tests[alg_ops[5]] = [1, 3, 4, 5, 6, 8, 9, 11, 12, 15, 21]
broken_tests[alg_ops[6]] = [3, 4, 5, 6, 8, 9, 11, 12, 21]

skip_tests = Dict(alg => Int[] for alg in alg_ops)
skip_tests[alg_ops[1]] = [2, 22]
skip_tests[alg_ops[2]] = [2, 22]
skip_tests[alg_ops[3]] = [2, 22]
skip_tests[alg_ops[4]] = [2, 22]
skip_tests[alg_ops[5]] = [2, 22]
skip_tests[alg_ops[6]] = [2, 22]

test_on_library(problems, dicts, alg_ops, broken_tests; skip_tests)
broken_tests[alg_ops[5]] = [1, 2, 3, 4, 5, 6, 8, 9, 11, 12, 15, 21]
broken_tests[alg_ops[6]] = [2, 3, 4, 5, 6, 8, 9, 11, 12, 21, 22]

test_on_library(problems, dicts, alg_ops, broken_tests)
end

@testset "Klement 23 Test Problems" begin
Expand Down
Loading