-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create SimpleNonlinearSolve_Kernel_Tutorial.md #423
base: master
Are you sure you want to change the base?
Conversation
- AMDGPU.jl (for AMD GPUs) | ||
|
||
## Writing the Kernel | ||
Define a kernel using <b>'@kernel'</b> from <b>'KernelAbstractions.jl'</b> to solve a single initial condition. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not directly use the markdown syntax?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed to md syntax
## Writing the Kernel | ||
Define a kernel using <b>'@kernel'</b> from <b>'KernelAbstractions.jl'</b> to solve a single initial condition. | ||
|
||
```@example kenel |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To ensure the consistency of example environment, here should be kernel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah made the changes
Is any change required in the tutorial content?? |
|
||
### Prerequisites | ||
Ensure the following packages are installed: | ||
- Julia (v1.6 or later) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1.10
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah changed the version
# Threaded CPU | ||
vectorized_solve(prob, SimpleNewtonRaphson(); backend = CPU()) | ||
|
||
# AMD ROCM GPU | ||
vectorized_solve(prob, SimpleNewtonRaphson(); backend = ROCBackend()) | ||
|
||
# NVIDIA CUDA GPU | ||
vectorized_solve(prob, SimpleNewtonRaphson(); backend = CUDABackend()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment out the ones that can't be run on the server
Use a filename that is consistent with the other files |
@@ -0,0 +1,83 @@ | |||
# Using SimpleNonlinearSolve with KernelAbstractions.jl |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using Nonlinear Solvers inside GPU Kernels
Changed the name you suggested |
# Threaded CPU | ||
# vectorized_solve(prob, SimpleNewtonRaphson(); backend = CPU()) | ||
|
||
# AMD ROCM GPU | ||
# vectorized_solve(prob, SimpleNewtonRaphson(); backend = ROCBackend()) | ||
|
||
# NVIDIA CUDA GPU | ||
# vectorized_solve(prob, SimpleNewtonRaphson(); backend = CUDABackend()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dont' comment everything out 😓
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #423 +/- ##
==========================================
- Coverage 86.30% 79.84% -6.46%
==========================================
Files 47 47
Lines 2913 2908 -5
==========================================
- Hits 2514 2322 -192
- Misses 399 586 +187 ☔ View full report in Codecov by Sentry. |
Doc build is failing |
Is there any syntax issue in the documentation. Ideally it shouldn't happen |
You can check the failure https://github.com/SciML/NonlinearSolve.jl/actions/runs/8947164779/job/24579133735?pr=423. In any case, you should be running the code locally before pushing it. |
Sure! Some packages are not installed in the dev while running the code. Also the backend servers are not defined. I'll make the changes soon. |
No description provided.