Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add NonlinearSolveHomotopyContinuation.jl #523

Merged
merged 24 commits into from
Jan 31, 2025

Conversation

AayushSabharwal
Copy link
Member

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

@ChrisRackauckas
Copy link
Member

What is left here?

@AayushSabharwal
Copy link
Member Author

JuliaHomotopyContinuation/HomotopyContinuation.jl#609

TL;DR: Despite testing the custom system/homotopy here the same way HomotopyContinuation.jl tests theirs, the solve fails because NaNs creep in somewhere somehow. I haven't yet been able to figure out why.

@AayushSabharwal AayushSabharwal changed the title [WIP] feat: add NonlinearSolveHomotopyContinuation.jl feat: add NonlinearSolveHomotopyContinuation.jl Jan 26, 2025
@ChrisRackauckas
Copy link
Member

Add this to the CI

@AayushSabharwal
Copy link
Member Author

This is a bit stochastic since whether HC considers a root "real" depends on if the imaginary part is less than the accuracy of their solve. Sometimes their results are more accurate, sometimes less.

@ChrisRackauckas
Copy link
Member

That should be easily patchable on their end in like a day?

@AayushSabharwal
Copy link
Member Author

@ChrisRackauckas
Copy link
Member

It would be nice to have a short tutorial that showcases a place where Newton methods fail but this gives an accurate answer. Do you have one?

@AayushSabharwal
Copy link
Member Author

iirc bruss with some guesses can show this behavior. Will write something

@ChrisRackauckas ChrisRackauckas merged commit 7bb635d into SciML:master Jan 31, 2025
11 of 16 checks passed
@AayushSabharwal AayushSabharwal deleted the as/hc branch January 31, 2025 05:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants