Skip to content

Address some of the comments

Codecov / codecov/project failed Jan 16, 2024 in 0s

69.03% (-14.77%) compared to b661754

View this Pull Request on Codecov

69.03% (-14.77%) compared to b661754

Details

Codecov Report

Attention: 702 lines in your changes are missing coverage. Please review.

Comparison is base (b661754) 83.79% compared to head (3db75f0) 69.03%.

❗ Current head 3db75f0 differs from pull request most recent head ca15839. Consider uploading reports for the commit ca15839 to get more accurate results

Files Patch % Lines
src/core/approximate_jacobian.jl 51.94% 74 Missing ⚠️
src/globalization/line_search.jl 51.47% 66 Missing ⚠️
src/globalization/trust_region.jl 72.00% 56 Missing ⚠️
src/core/spectral_methods.jl 45.67% 44 Missing ⚠️
src/internal/approximate_initialization.jl 67.44% 42 Missing ⚠️
src/core/generalized_first_order.jl 64.34% 41 Missing ⚠️
src/utils.jl 44.44% 40 Missing ⚠️
src/algorithms/lbroyden.jl 55.40% 33 Missing ⚠️
src/internal/forward_diff.jl 0.00% 32 Missing ⚠️
src/descent/damped_newton.jl 78.16% 31 Missing ⚠️
... and 22 more
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #345       +/-   ##
===========================================
- Coverage   83.79%   69.03%   -14.77%     
===========================================
  Files          28       44       +16     
  Lines        2179     2603      +424     
===========================================
- Hits         1826     1797       -29     
- Misses        353      806      +453     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.