Added MOO functionality to functions.jl #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have updated the instantiate_function to handle the MOOFunction.
Updated instantiate_function to work for MOO in function.jl
Changed the position of the MOO function checks in instantiate_function.
src/function.jl
Outdated
| observed = f.observed) | ||
| end | ||
|
|
||
| function instantiate_function(f::MultiObjectiveOptimizationFunction, x, adtype::ADTypes.AbstractADType, |
There was a problem hiding this comment.
Remove this and change the dispatch of this on OptimizationFunction to AbstractOptimizationFunction
There was a problem hiding this comment.
Actually that doesn't even have a type on f right now so I think it should just work so you can just remove this
Removed the dispatch as per the review comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added an _instantiate_function that works for MOO in functions.jl
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.