Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added ROS2 method and added ROS2, ROS23 and ROS34PW methods to iipvsoop_test.jl #2165

Merged
merged 4 commits into from
Apr 21, 2024
Merged

added ROS2 method and added ROS2, ROS23 and ROS34PW methods to iipvsoop_test.jl #2165

merged 4 commits into from
Apr 21, 2024

Conversation

cwittens
Copy link
Contributor

Checklist

  • Appropriate tests were added
  • Any code changes were done in a way that does not break public API
  • All documentation related to code changes were updated
  • The new code follows the
    contributor guidelines, in particular the SciML Style Guide and
    COLPRAC.
  • Any new documentation only uses public API

Additional context

Add any other context about the problem here.

closes #2112

@cwittens cwittens mentioned this pull request Mar 28, 2024
Merged
5 tasks
ranocha
ranocha requested changes Mar 28, 2024
View reviewed changes
Copy link
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! This looks mostly good to me. Did you test it also with some additional ODEs?

src/generic_rosenbrock.jl Outdated Show resolved Hide resolved
src/generic_rosenbrock.jl Show resolved Hide resolved
cwittens and others added 2 commits March 29, 2024 16:56
@cwittens @ranocha
Update src/generic_rosenbrock.jl
99ef26d 
Co-authored-by: Hendrik Ranocha <[email protected]>
@cwittens @ranocha
Update src/generic_rosenbrock.jl
2cbaf2e 
Co-authored-by: Hendrik Ranocha <[email protected]>
@cwittens
Copy link
Contributor Author

Thanks a lot! This looks mostly good to me. Did you test it also with some additional ODEs?

What do you mean?

@ranocha
Copy link
Member

ranocha commented Mar 31, 2024

Thanks a lot! This looks mostly good to me. Did you test it also with some additional ODEs?

What do you mean?

There are some tests in the test folder. Did you also run the new method for additional ODEs to check that they work as expected?

Anyway, nice work 👍

@ranocha
Copy link
Member

ranocha commented Mar 31, 2024

Some Rosenbrock tests fail - I guess that's related to this PR?

@ChrisRackauckas
Copy link
Member

yes definitely introduced here

@cwittens
fixed tests in ode_rosenbrock_tests.jl
ab4872f 
I thought the problem was related to the changes in "iipvscoop_test.jl", but the problem just that 60 < 60 is False. I fixed that now and it should work now. (all test passed locally at least)
@ranocha
Copy link
Member

ranocha commented Apr 21, 2024

Most failing CI runs are caused by Codecov (see codecov/feedback#301). The only exception is https://github.com/SciML/OrdinaryDiffEq.jl/actions/runs/8753631634/job/24023730348?pr=2165#step:6:956

Could you please check whether this PR causes that or whether this happens also on the current master branch?

@ChrisRackauckas
Copy link
Member

This PR doesn't cause that. I need to fix that one up.

But those Rosenbrock tests need to be added here.

@ChrisRackauckas
Copy link
Member

Okay yeah this looks good.

@ChrisRackauckas ChrisRackauckas merged commit bbb3ee0 into SciML:master Apr 21, 2024
8 of 32 checks passed
@cwittens cwittens deleted the ROS2 branch April 22, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ranocha ranocha ranocha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Second-order Rosenbrock method of Verwer, Spee, Blom, Hundsdorfer (1999)
3 participants
@cwittens @ranocha @ChrisRackauckas