Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix ensemble indexing #472

Merged
merged 2 commits into from
Jul 21, 2023

Conversation

oscardssmith
Copy link
Contributor

This fixes the indexing issues for Ensembles without the breaking parts of #466.

@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Merging #472 (30c3f74) into master (34c4f13) will decrease coverage by 16.63%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           master     #472       +/-   ##
===========================================
- Coverage   53.48%   36.86%   -16.63%     
===========================================
  Files          47       47               
  Lines        3575     3562       -13     
===========================================
- Hits         1912     1313      -599     
- Misses       1663     2249      +586     
Impacted Files Coverage Δ
src/ensemble/ensemble_solutions.jl 29.62% <100.00%> (-1.28%) ⬇️

... and 32 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ChrisRackauckas ChrisRackauckas merged commit 1aee21d into SciML:master Jul 21, 2023
54 of 61 checks passed
@oscardssmith oscardssmith deleted the ensemble-indexing-fixes branch July 21, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants