Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make DDEProblem mutable #723

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Make DDEProblem mutable #723

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dc9bc71
ddeproblem mutable (enzyme compat)
m-bossart Jun 26, 2024
7bd450d
Merge branch 'SciML:master' into mb/ddeproblem-mutable
m-bossart Jul 3, 2024
778f603
Merge branch 'SciML:master' into mb/ddeproblem-mutable
m-bossart Aug 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 11 additions & 1 deletion src/problems/dde_problems.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ prob = DDEProblemLibrary.prob_dde_constant_1delay_ip
sol = solve(prob)
```
"""
struct DDEProblem{uType, tType, lType, lType2, isinplace, P, F, H, K, PT} <:
mutable struct DDEProblem{uType, tType, lType, lType2, isinplace, P, F, H, K, PT} <:
AbstractDDEProblem{uType, tType, lType, isinplace}
f::F
u0::uType
Expand Down Expand Up @@ -259,6 +259,16 @@ function DDEProblem(f::AbstractDDEFunction, args...; kwargs...)
DDEProblem{isinplace(f)}(f, args...; kwargs...)
end

function Base.setproperty!(prob::DDEProblem, s::Symbol, v)
@warn "Mutation of DDEProblem detected. DDEProblem is temporarily mutable in order to allow for interfacing with EnzymeRules due to a current limitation in the rule system. This change is only intended to be temporary and ODEProblem will return to being a struct in a later non-breaking release. Do not rely on this behavior, use with caution."
Base.setfield!(prob, s, v)
end

function Base.setproperty!(prob::DDEProblem, s::Symbol, v, order::Symbol)
@warn "Mutation of DDEProblem detected. DDEProblem is temporarily mutable in order to allow for interfacing with EnzymeRules due to a current limitation in the rule system. This change is only intended to be temporary and ODEProblem will return to being a struct in a later non-breaking release. Do not rely on this behavior, use with caution."
Base.setfield!(prob, s, v, order)
end

"""
$(TYPEDEF)
"""
Expand Down