Fix CSV parsing of empty fields, NaN and Inf values #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need more, better to restrict ourselves, especially thanks to the dead code elimination bug.
Essentially the logic is as follows: - empty fields are allowed and are treated as NaN (unless they are already determined to be strings) - if an integer column encounters a missing value, it will be converted to float - explicit NaN and Inf values are now parsed correctly
This indicates the row number in which the data starts so that we know how many rows to skip.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This improves the CSV parser to address (most) of the issues of #19.
For the unaddressed "issues" see the comment in the issue.
Closes #19.