Skip to content

Commit

Permalink
[tests] disable tests expected to fail w/o threads:on
Browse files Browse the repository at this point in the history
Nowadays we compile with `--threads:on` by default!
  • Loading branch information
Vindaar committed Apr 9, 2024
1 parent 82e973b commit 59288c2
Showing 1 changed file with 14 additions and 13 deletions.
27 changes: 14 additions & 13 deletions tests/plotly/test_api.nim
Original file line number Diff line number Diff line change
Expand Up @@ -495,20 +495,21 @@ suite "show w/ filename without threads fails compilation":
xs: xs, ys: ys)
let plt = Plot[float](layout: layout, traces: @[d])

## NOTE: the following tests assume the test is compiled without `--threads:on`!
test "Plot - saveImage fails":
check compileFails(plt.saveImage("test.svg"))
when not compileOption("threads"):
## NOTE: the following tests assume the test is compiled without `--threads:on`!
test "Plot - saveImage fails":
check compileFails(plt.saveImage("test.svg"))

test "PlotJson - saveImage fails":
check compileFails(plt.toPlotJson.saveImage("test.svg"))
test "PlotJson - saveImage fails":
check compileFails(plt.toPlotJson.saveImage("test.svg"))

test "Plot - show w/ filename w/o threads:on fails":
check compileFails(plt.show("test.svg"))
test "Plot - show w/ filename w/o threads:on fails":
check compileFails(plt.show("test.svg"))

test "PlotJson - show w/ filename w/o threads:on fails":
check compileFails(plt.toPlotJson.show("test.svg"))
test "PlotJson - show w/ filename w/o threads:on fails":
check compileFails(plt.toPlotJson.show("test.svg"))

test "Grid - show w/ filename w/o threads:on fails":
var grid = createGrid(1)
grid[0] = plt
check compileFails(grid.show("test.svg"))
test "Grid - show w/ filename w/o threads:on fails":
var grid = createGrid(1)
grid[0] = plt
check compileFails(grid.show("test.svg"))

0 comments on commit 59288c2

Please sign in to comment.