Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposes the same interface to import JSON or VOTable #59

Merged
merged 4 commits into from
Jun 7, 2024

Conversation

jeandet
Copy link
Member

@jeandet jeandet commented Jun 5, 2024

This is necessary to implement import/export of votables on GUI side.

jeandet added 2 commits June 5, 2024 12:16
Signed-off-by: Alexis Jeandet <[email protected]>
@jeandet jeandet requested a review from pboettch June 5, 2024 10:29
Copy link

codecov bot commented Jun 5, 2024

Codecov Report

Attention: Patch coverage is 76.92308% with 9 lines in your changes missing coverage. Please review.

Project coverage is 99.51%. Comparing base (61e03dd) to head (04a201d).
Report is 4 commits behind head on main.

Current head 04a201d differs from pull request most recent head 56363b0

Please upload reports for the commit 56363b0 to get more accurate results.

Files Patch % Lines
tscat/import_export.py 64.00% 9 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              main      #59      +/-   ##
===========================================
- Coverage   100.00%   99.51%   -0.49%     
===========================================
  Files           14       14              
  Lines         1836     1858      +22     
===========================================
+ Hits          1836     1849      +13     
- Misses           0        9       +9     
Flag Coverage Δ
unittests 99.51% <76.92%> (-0.49%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jeandet jeandet force-pushed the unify_import_interface branch from 293f049 to 04a201d Compare June 5, 2024 12:56
Copy link

sonarqubecloud bot commented Jun 6, 2024

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@jeandet jeandet merged commit 20b2df6 into SciQLop:main Jun 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants