Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Safer Model Handle Creation #402

Merged

Conversation

martindevans
Copy link
Member

  • directly returning a SafeLlamaModelHandle, instead of an IntPtr which is wrapped in a handle.
  • made llama_backend_init private. This is automatically called, there is no way it can correctly be used externally.
  • made llama_token_to_piece safe (Span instead of pointer)

…ch is wrapped in a handle.

 - made `llama_backend_init` private. This is automatically called, there is no way it can correctly be used externally.
 - made `llama_token_to_piece` safe (Span instead of pointer)
@martindevans martindevans merged commit 9b9bcc0 into SciSharp:master Jan 2, 2024
3 checks passed
@martindevans martindevans deleted the safer_model_handle_creation branch January 2, 2024 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant