Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove quotes around printed enums #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nimrof
Copy link
Contributor

@nimrof nimrof commented Oct 31, 2023

Having problems reading enums with quotes around them user the official c++ implementation, removing them fixes the problem.

I can make this optional if wanted.

official examples of this can be found here:
https://protobuf.dev/reference/protobuf/textformat-spec/#text-format-files
https://protobuf.dev/reference/protobuf/textformat-spec/#example

I have problems finding any prof that this is the case in the c++ code
The best prof i found is to look in the test file below and search for enum
https://github.com/protocolbuffers/protobuf/blob/3667102d91bba05afcb777aa685b1014f521e9bc/src/google/protobuf/text_format_unittest.cc

@nimrof nimrof changed the title remove quotes around enums remove quotes around printed enums Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant