-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ruff rule D411 compliance. #5657
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5657 +/- ##
=======================================
Coverage 89.69% 89.69%
=======================================
Files 90 90
Lines 22807 22807
Branches 5441 5441
=======================================
Hits 20456 20456
Misses 1618 1618
Partials 733 733 ☔ View full report in Codecov by Sentry. |
bjlittle
approved these changes
Dec 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
tkknight
added a commit
to tkknight/iris
that referenced
this pull request
Dec 20, 2023
* upstream/main: ruff rule D411 compliance. (SciTools#5657) ruff rule D208 compliance. (SciTools#5656)
tkknight
added a commit
to tkknight/iris
that referenced
this pull request
Dec 20, 2023
* upstream/main: ruff rule D411 compliance. (SciTools#5657) ruff rule D208 compliance. (SciTools#5656)
tkknight
added a commit
to tkknight/iris
that referenced
this pull request
Dec 20, 2023
* upstream/main: ruff rule D411 compliance. (SciTools#5657) ruff rule D208 compliance. (SciTools#5656)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
PR solely for fixing
D411: Missing blank line before section
Continues work of #5625.
I used the
noqa
directive here as a few of the docstrings containAttributes:
in the docstest content and ruff thinks it is an over indented title, which it is not. This will be a pattern for future docstrings that contains this.Consult Iris pull request check list