ruff compliance for D409 and D410. #5662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* upstream/main: ruff rule D411 compliance. (SciTools#5657) ruff rule D208 compliance. (SciTools#5656)
for more information, see https://pre-commit.ci
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5662 +/- ##
=======================================
Coverage 89.69% 89.69%
=======================================
Files 90 90
Lines 22807 22807
Branches 5441 5441
=======================================
Hits 20456 20456
Misses 1618 1618
Partials 733 733 ☔ View full report in Codecov by Sentry. |
* refs/remotes/origin/ruff9: [pre-commit.ci] auto fixes from pre-commit.com hooks
bjlittle
approved these changes
Dec 20, 2023
|
@tkknight LGTM 👍 Just need to resolve your file conflicts, then we're good to bank this. |
* upstream/main: ruff rule D211, D300, D403 compliance. (SciTools#5661) ruff rule D412 compliance. (SciTools#5660)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
PR solely for fixing:
D409: Section underline should match the length of its nameD410 Missing blank line after sectionContinues work of #5625.
Consult Iris pull request check list