Adds a warning for iris.coord_categorisation.add_season_membership that this is not saveable as a boolean coordinate.
#6305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6305 +/- ##
==========================================
- Coverage 89.88% 89.85% -0.03%
==========================================
Files 88 88
Lines 23315 23402 +87
Branches 4338 4356 +18
==========================================
+ Hits 20956 21029 +73
- Misses 1628 1646 +18
+ Partials 731 727 -4 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Description
This addresses #5909, by raising a warning that since this adds a boolean, the result will not be saveable to a Netcdf file since it contains a boolean coordinate.
Note for reviewer:
I was not 100% sure on the type of error to raise either
iris.warnings.IrisSaveWarningoriris.warnings.IrisCfSaveWarningsince this a problem with Netcdf files.