Skip to content

Conversation

@stephenworsley
Copy link
Contributor

🚀 Pull Request

Closes #6228

@CLAassistant
Copy link

CLAassistant commented Oct 20, 2025

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Oct 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.29%. Comparing base (9c06cca) to head (9b0eae6).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6754   +/-   ##
=======================================
  Coverage   90.29%   90.29%           
=======================================
  Files          91       91           
  Lines       24656    24659    +3     
  Branches     4618     4619    +1     
=======================================
+ Hits        22264    22267    +3     
  Misses       1620     1620           
  Partials      772      772           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@stephenworsley stephenworsley marked this pull request as ready for review October 22, 2025 10:14
Copy link
Member

@pp-mo pp-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've suggested some ways to make the code cleaner, and (I think) easier to read.
Also some further tests.

Your earlier suggestion of adding some integration tests is also a good idea, I think.
But that can probably wait while we attend to other things, along with whatsnew content etc.

pp-mo
pp-mo previously requested changes Oct 23, 2025
Copy link
Member

@pp-mo pp-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One final small tweak, and all good !

@pp-mo pp-mo enabled auto-merge (squash) October 23, 2025 16:58
@pp-mo pp-mo dismissed their stale review October 27, 2025 07:42

All done

Copy link
Member

@pp-mo pp-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good now

@pp-mo pp-mo merged commit 466b7d4 into SciTools:main Oct 27, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Multiple NetCDF name constraints before Cube creation

3 participants