Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QA: Remove warn_unreachable=true from mypy config #301

Merged
merged 1 commit into from
Nov 21, 2024
Merged

QA: Remove warn_unreachable=true from mypy config #301

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,11 +66,11 @@ disable_error_code = [
"misc",
"no-untyped-call",
"no-untyped-def",
"unreachable",
"unreachable", # TODO: Uncomment `warn_unreachable` below when fixed
]
enable_error_code = ["ignore-without-code", "redundant-expr", "truthy-bool"]
strict = true
warn_unreachable = true
# warn_unreachable = true # TODO: Enable once all unreachable code is fixed

[tool.numpydoc_validation]
checks = [
Expand Down Expand Up @@ -136,6 +136,7 @@ ignore = [

# TODO: exceptions that still need investigating are below.
# Might be fixable, or might become permanent (above):
"MY103", # Must have warn_unreachable enabled in mypy
"PY007", # Supports an easy task runner (nox or tox)
"PP309", # Filter warnings specified
"PC170", # Uses PyGrep hooks (only needed if rST present)
Expand Down
Loading