pgadmin4-np: Silent user install support #354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refresh of installer arguments in order to: * support silent installs in both user and global contexts => `SUPPRESSMSGBOXES` will let the installer assume local user install if it does not have admin rights instead of asking for elevated privileges * get rid of a post_install error in case of local user install (because 'pgAdmin 4' folder can't be located under the common start menu) by using `NOICONS` during install instead of trying to remove start menu icons after the fact
|
All changes look good. Wait for review from human collaborators. pgadmin4-np
|
|
Sorry for the ping but could I maybe ask a review from you @HUMORCE ? I need this for non-admin installs on several machines. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refresh of installer arguments in order to:
support silent installs in both user and global contexts =>
SUPPRESSMSGBOXESwill let the installer assume local user install if it does not have admin rights instead of asking for elevated privilegesget rid of a post_install error in case of local user install (because 'pgAdmin 4' folder can't be located under the common start menu) by using
NOICONSduring install instead of trying to remove start menu icons after the fact