-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(install): fallback to default downloader when aria2 fails #4292
fix(install): fallback to default downloader when aria2 fails #4292
Conversation
44d5c60
to
599d631
Compare
It would be better to not make this a default, and control it with a config variable instead. @kiennq can you fix the conficts? |
A refactoring of |
|
599d631
to
58feb11
Compare
I think it should be by default as this only fallback when the aria2 downloading fail. The warning and instruction to file a bug for aria2 is still showing though.
I think once aria2 fails, it would be better to fall back into the default one instead of retrying with aria2 again, no?
@niheaven Done |
Yea it's prob better to fallback to the default DLer. I remember when I had some wonky NIC driver settings, aria2c would fail (not really aria2c's fault tbf), but the default DLer worked, I take my last message back. |
Co-authored-by: Hsiao-nan Cheung <[email protected]>
Now you could add a changlog entry now. |
Done |
Try to fallback to default downloader when aria2 download failed.
This make the download with aria2 more stable since there's some download links that doesn't support multi-connection.
Closes #4472