Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(install): fallback to default downloader when aria2 fails #4292

Merged
merged 3 commits into from
Aug 26, 2024

Conversation

kiennq
Copy link
Contributor

@kiennq kiennq commented Mar 13, 2021

Try to fallback to default downloader when aria2 download failed.
This make the download with aria2 more stable since there's some download links that doesn't support multi-connection.

Closes #4472

@kiennq kiennq force-pushed the fix/fallback-from-aria2 branch from 44d5c60 to 599d631 Compare June 20, 2021 16:10
@rashil2000
Copy link
Member

It would be better to not make this a default, and control it with a config variable instead. @kiennq can you fix the conficts?

@niheaven
Copy link
Member

A refactoring of install.ps1 by separate downloading, extracting, and installing will be done after this release, and could you do the resolving after that?

@brian6932
Copy link

brian6932 commented Aug 31, 2022

Would it not be better to just set aria2-max-connection-per-server to 1 if the download fails on retry?

@kiennq kiennq force-pushed the fix/fallback-from-aria2 branch from 599d631 to 58feb11 Compare August 18, 2024 08:47
@kiennq
Copy link
Contributor Author

kiennq commented Aug 18, 2024

It would be better to not make this a default, and control it with a config variable instead. @kiennq can you fix the conficts?

I think it should be by default as this only fallback when the aria2 downloading fail. The warning and instruction to file a bug for aria2 is still showing though.

Would it not be better to just set aria2-max-connection-per-server to 1 if the download fails on retry?

I think once aria2 fails, it would be better to fall back into the default one instead of retrying with aria2 again, no?

A refactoring of install.ps1 by separate downloading, extracting, and installing will be done after this release, and could you do the resolving after that?

@niheaven Done

@brian6932
Copy link

brian6932 commented Aug 18, 2024

I think once aria2 fails, it would be better to fall back into the default one instead of retrying with aria2 again, no?

Yea it's prob better to fallback to the default DLer. I remember when I had some wonky NIC driver settings, aria2c would fail (not really aria2c's fault tbf), but the default DLer worked, I take my last message back.

lib/download.ps1 Show resolved Hide resolved
lib/download.ps1 Outdated Show resolved Hide resolved
Co-authored-by: Hsiao-nan Cheung <[email protected]>
@niheaven
Copy link
Member

Now you could add a changlog entry now.

@kiennq
Copy link
Contributor Author

kiennq commented Aug 23, 2024

Now you could add a changlog entry now.

Done

@niheaven niheaven merged commit e0c682d into ScoopInstaller:develop Aug 26, 2024
2 checks passed
@kiennq kiennq deleted the fix/fallback-from-aria2 branch August 26, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants