Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #4062 - autoupdate to use useragent #5043

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

vmvmpvm
Copy link

@vmvmpvm vmvmpvm commented Jul 12, 2022

Description

Motivation and Context

Closes #4062

How Has This Been Tested?

Tested a manifest with autoupdate.useragent specified (precedence), and checkver.useragent specified (fallback).

Checklist:

  • I have read the Contributing Guide.
  • I have ensured that I am targeting the develop branch.
  • I have updated the documentation accordingly.
  • I have updated the tests accordingly.
  • I have added an entry in the CHANGELOG.

@AntonOks
Copy link

AntonOks commented May 9, 2024

@niheaven @chawyehsu

Eagerly waiting, since ever. Will this ever be merged?

@niheaven
Copy link
Member

The download refactoring is currently in progress; please wait for a moment.

@vmvmpvm vmvmpvm force-pushed the master branch 2 times, most recently from afecd8e to 23c963a Compare May 10, 2024 06:30
@JourneyOver
Copy link

Any word on this possibly getting merged?

@AntonOks
Copy link

AntonOks commented Nov 18, 2024

The download refactoring is currently in progress; please wait for a moment.

@niheaven @HUMORCE @rashil2000

So, with the latest push the refactoring is considered to be done, right?
Will this finally be merged NOW?

@niheaven
Copy link
Member

Apologies for the inconvenience, as I am currently quite occupied. The refactoring is ongoing and is expected to be completed in about a month.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants