-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(scoop-download|install|update): Use consistent options #5956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prefer renaming all args to |
@niheaven Agreed. Will update later. |
niheaven
previously approved these changes
May 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, wait for other maintainers
-h
-> -s
niheaven
previously approved these changes
May 10, 2024
niheaven
approved these changes
May 14, 2024
brian6932
pushed a commit
to brian6932/Scoop
that referenced
this pull request
Jun 1, 2024
niheaven
pushed a commit
that referenced
this pull request
Jun 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is to fix a bug: the shorthand of the option--no-hash-check
for the commandscoop download
should be-s
instead of-h
to be consistent withscoop install
andscoop update
, since the flag-h
always means printing help text for a command.BTW, the option--no-hash-check
forscoop download
is also inconsistent with--skip
forscoop install
orscoop update
, even though they work the same way. For backwards compatibility, I did not adjust it. Should we?EDITED: Use consistent options (
-s/--skip-hash-check
) forscoop download
,scoop install
andscoop update
.How Has This Been Tested?
- Runscoop download -h
, and it prints the help text for us.- Runscoop download -s <app>
, and it skips the hash verification after the download, which is the expected behavior.Run the following to check available CLI options in the help text:
scoop download -h
scoop install -h
scoop update -h
Run the following to skip hash validation:
scoop download -s <app>
scoop download --skip-hash-check <app>
scoop install -s <app>
scoop install --skip-hash-check <app>
scoop update -s <app>
scoop update --skip-hash-check <app>
Checklist:
develop
branch.