Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: small frontend improvements #10

Merged
merged 5 commits into from
Aug 7, 2023
Merged

chore: small frontend improvements #10

merged 5 commits into from
Aug 7, 2023

Conversation

mds1
Copy link
Contributor

@mds1 mds1 commented Aug 2, 2023

  • The default form data is present in dev mode but not in production, so no changes needed there.
  • Add banner linking to signup page for more info https://www.scopelift.co/cove
  • Add a tooltip explaining partial vs full match. The tooltip is very narrow, I think it's getting constrained by the flexbox it's in. @alexkeating @wildmolasses if either of you can fix it quickly that'd be great, but I don't think it's worth spending much time on
  • Stricter lint rules

Let me know any other tweaks we want to add to this PR

@netlify
Copy link

netlify bot commented Aug 2, 2023

Deploy Preview for cove-frontend-0 ready!

Name Link
🔨 Latest commit 1218ed1
🔍 Latest deploy log https://app.netlify.com/sites/cove-frontend-0/deploys/64cfd4fbbd0ae2000870ef4f
😎 Deploy Preview https://deploy-preview-10--cove-frontend-0.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mds1 mds1 marked this pull request as draft August 2, 2023 23:21
@alexkeating
Copy link
Contributor

I think the issue is the relative, and absolute, but not a 100% how to fix as I am not well versed in tailwind

@mds1 mds1 marked this pull request as ready for review August 4, 2023 18:39
Copy link
Contributor

@alexkeating alexkeating left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

src/lib/cove-api.ts Show resolved Hide resolved
@mds1 mds1 merged commit d128624 into main Aug 7, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants